Skip to content

Adding WiFiManager Example Sketches #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 30, 2022
Merged

Adding WiFiManager Example Sketches #161

merged 19 commits into from
Aug 30, 2022

Conversation

bradrblack
Copy link
Contributor

** Scope: Added example sketch to use WiFiManager to configure SSID and Password and connect to WiFi on ESP8266 and ESP32 microcontrollers. No need to hard-code WiFi parameters in your sketch that connects to AdafruitIO.

** Limitations: WiFiManager supports ESP8266 and ESP32 boards only.

** Tests: Tested using 4.2.2 AdafruitIO library on ESP8266 and ESP32 microcontrollers. ESP32 requires newer WiFiManager development branch - tested with: https://github.com/tzapu/WiFiManager.git@^2.0.5-beta

brentru
brentru requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place this sketch in a folder such that the folder name exactly matches the sketch name.

Example path: examples/adafruitio_27_wifimanager/adafruitio_27_wifimanager.ino

@bradrblack
Copy link
Contributor Author

I moved the sketch to a subfolder as requested.

@bradrblack bradrblack changed the title Adding WiFiManager Example Sketch Adding WiFiManager Example Sketches Aug 20, 2022
@brentru
Copy link
Member

brentru commented Aug 22, 2022

@bradrblack Almost there - please include WiFiManager in the depends list within library.properties (https://github.com/adafruit/Adafruit_IO_Arduino/blob/master/library.properties#L10)

@brentru
Copy link
Member

brentru commented Aug 22, 2022

Also - since these examples are only for the ESP8266 and ESP32.

Please place 2 empty files in each example folder:
pyportal.test.skip
metro_m4_airliftlite.test.skip

This will tell our CI to skip testing the examples you added for the SAMD platforms.

@bradrblack
Copy link
Contributor Author

Made changes as requested. I think the skip files need to start with a "." like ".pyportal.test.skip". So I change to that.

@brentru
Copy link
Member

brentru commented Aug 30, 2022

@bradrblack Looks perfect. Thanks for adding this example, a lot of people on the forums ask about this so it'll be a great resource to point people towards.

Finally, please bump the version number in the library.properties file to 4.2.3. I'll merge and release once this is done.

@brentru brentru merged commit a21c9a3 into adafruit:master Aug 30, 2022
@brentru brentru mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradrblack @brentru