On Thu, May 8, 2025 at 12:59 PM foamyguy ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thanks for submitting this new driver. I think we need a few more things before it's ready to merge. - The libraries that are added need to have at least 1 release made. The page here details the process to do that: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/releasing-on-github - I think something is off with the added submodule, I've noted down in the code with a separate comment some more details - I'm not certain if this one will matter, but I noticed the actions for your library don't pass currently: https://github.com/joepardue/circuitpython-as7343/actions and that you don't have the release actions that are typically used for circuitpython libraries. I don't know off the top of my head whether that will cause the bundling process to fail when it tries to build. If so then the easiest way to get all of the requisite files is to use cookiecutter as described on this page: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/creating-a-library to generate a project template which will include all of the necessary infrastructure files. ------------------------------ In libraries/drivers/libraries/drivers/circuitpython-as7343/.gitmodules <#254 (comment)> : > @@ -0,0 +1 @@ + I think this part of the git add didn't work properly or something. It's showing just an empty .gitmodules file as the contents of the new repo. Ordinarily in the github interface this would show a link out to the other repo and a hash of the current commit: image.png (view on web) <https://github.com/user-attachments/assets/66e0f5d7-9e8d-43e4-bfd3-79d3f612f91b> I'm not sure of the exact right way to fix it. I suspect it will be something like deleting this empty .gitmodules file and then updating submodules in this branch that has the new library added, that should fetch the contents of the new library which could then be commit / pushed to this branch I think. I'll try to tinker with this a little later and see if I can figure out the way to get it corrected with more certainty. — Reply to this email directly, view it on GitHub <#254 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJBELVL47L6GUPSN6IAY4L25OEN5AVCNFSM6AAAAAB4W5TGQCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMRVG44TOOJWGI> . You are receiving this because you authored the thread.Message ID: ***@***.*** .com>