Skip to content

Migrate CI To GitHub Actions #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 1, 2019
Merged

Conversation

sommersoft
Copy link
Collaborator

This is what I came up with based on the Actions templates.

The Community bundle has non-default package folder prefixes compared to the Adafruit bundle (default: adafruit_). I previously solved this by hard coding the prefixes into .travis.yml (never merged into master though). In this iteration, I used a gawk routine to identify repeating folders (e.g. libraries/helpers/dotstar_featherwing/dotstar_featherwing), and build the list of prefixes that way.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you!

I won't merge since there are a number of other reviewers listed.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@kattni kattni merged commit 7f5a6e2 into adafruit:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants