Skip to content

PID for new boards #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Targett363 opened this issue Oct 14, 2020 · 6 comments
Closed

PID for new boards #3553

Targett363 opened this issue Oct 14, 2020 · 6 comments
Assignees
@dhalbert

Comments

@Targett363
Copy link

Hi I'm going through Kattni's How to "Add a New Board to CircuitPython" for my ESP32S2 Module Clip board and I'm pretty much there except for needing a VID&PID, well 2 I guess as you can attach either WROOM or WROVER variants to the board.

The guide suggests asking for help here...
@dhalbert
Copy link
Collaborator

Could you give us a "manufacturer" name and official board names?

@Targett363
Copy link
Author

Targett363 commented Oct 14, 2020 •
edited
Loading

I am the Manufacturer "Targett" and the Board names are "ESP32S2 Module Clip" Wroom and Wrover.
I'd propose the name targett_module_clip_wroom and targett_module_clip_wrover in my fork.

@Targett363
Copy link
Author

https://www.tindie.com/products/20752/

@tannewt
Copy link
Member

tannewt commented Oct 14, 2020

@Targett363 I saw your PR to pid.codes. I'll merge it into my aggregate PR and then you can use those.

@tannewt
Copy link
Member

tannewt commented Oct 14, 2020

Here is the other PR: pidcodes/pidcodes.github.com#564

@Targett363
Copy link
Author

Scott, tank you so much. Git newbie, I thought I'd done something fatally wrong over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhalbert dhalbert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tannewt @dhalbert @Targett363