Skip to content

TItle bar does not update after hard reset, from bad password to good password #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhalbert opened this issue Aug 5, 2022 · 2 comments · Fixed by #6715
Closed

TItle bar does not update after hard reset, from bad password to good password #6703

dhalbert opened this issue Aug 5, 2022 · 2 comments · Fixed by #6715
Assignees
@tannewt
Labels
espressif applies to multiple Espressif chips usb web workflow
Milestone
8.0.0

Comments

@dhalbert
Copy link
Collaborator

dhalbert commented Aug 5, 2022

I connected, then changed the wifi password to be wrong, did a hard reset. I see "Authentication Failure" after a 15-second or so delay. Then I changed the password back to be correct, and did another hard reset. On the device display (Feather ESP32S2 TFT), the IP address is shown, but the terminal title bar (running tio) said "No IP", and it did not show the code.py output:. This is a little bizarre because it should have come up properly and printed the usual initial text. Instead tio just said "Connected" and idid not print anything. This seems like some kind of timing problem.

From #6698 (review)
@dhalbert dhalbert added this to the 8.0.0 milestone Aug 5, 2022
@tannewt
Copy link
Member

tannewt commented Aug 8, 2022

Did the terminal title bar should "Auth failure" correctly? I suspect the issue may be that USB is coming up after the newest title bar updates have been sent since the display is connected from the get go.

I'll add a title bar update request when the dtr line is set over USB CDC. That way we'll send it again.

@tannewt tannewt added usb espressif applies to multiple Espressif chips labels Aug 8, 2022
@tannewt tannewt mentioned this issue Aug 8, 2022
Merged
@dhalbert
Copy link
Collaborator Author

dhalbert commented Aug 9, 2022

Did the terminal title bar should "Auth failure" correctly?

Right, exactly, I think your diagnosis is correct.

dhalbert pushed a commit that referenced this issue Aug 9, 2022
@tannewt
Request a title bar update on USB cdc connect
401c269 
This ensures that the USB serial connection gets a copy of the
latest title bar.

Fixes #6703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannewt tannewt

Labels
espressif applies to multiple Espressif chips usb web workflow
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Request a title bar update on USB cdc connect tannewt/circuitpython
2 participants
@tannewt @dhalbert