Skip to content

Regression in 8.1.0 due to ACEP-patch (refresh fails on e-paper) #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bablokb opened this issue Mar 16, 2023 · 5 comments
Closed

Regression in 8.1.0 due to ACEP-patch (refresh fails on e-paper) #7734

bablokb opened this issue Mar 16, 2023 · 5 comments

Comments

@bablokb
Copy link

bablokb commented Mar 16, 2023

CircuitPython version

Adafruit CircuitPython 8.1.0-beta.0 on 2023-03-01; Pimoroni Badger 2040 with rp2040

Code/REPL

na

Behavior

see below

Description

PR 931c7c1 (ACEP) changed the interface to the EPaperDisplay class replacing the (single byte) refresh_display_command with a refresh_sequence. Since this PR the Badger2040 flashes during refreshes but the screen remains black.

Additional information

No response

@bablokb bablokb added the bug label Mar 16, 2023
@bablokb
Copy link
Author

bablokb commented Mar 16, 2023

Fixed this by setting grayscale to True in the constructor. But this seems to be more a workaround than a fix, because the display is monochrome and not a grayscale display. So the switch to a refresh-sequence does not seem to be the root cause after all.

@tannewt
Copy link
Member

tannewt commented Mar 20, 2023

The code considers monochrome to be grayscale (versus having color.) What driver code are you using? It should set grayscale correctly.

@bablokb
Copy link
Author

bablokb commented Mar 22, 2023

It is an UC8151-chip. I will create a PR which fixes the board.c by setting grayscale to true.

@tannewt
Copy link
Member

tannewt commented Mar 22, 2023

I think #7777 may fix this more broadly. (I saw a similar issue on the forum.)

@tannewt tannewt added this to the 8.1.0 milestone Mar 22, 2023
@bablokb
Copy link
Author

bablokb commented Mar 22, 2023

Fixed by #7777

@bablokb bablokb closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants