Skip to content

must set pull after setting direction with gpio_set_pin routines #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

must set pull after setting direction with gpio_set_pin routines #1006

merged 1 commit into from
Jul 9, 2018

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jul 9, 2018

gpio_set_pin_pull_mode() must come after gpio_set_pin_direction(). I reversed this in one case because I thought it might avoid a glitch on the pin, but it didn't work.

This is an example of why we need HW regression tests.

@dhalbert dhalbert requested review from tannewt and kattni July 9, 2018 21:29
kattni
kattni approved these changes Jul 9, 2018
View reviewed changes
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Tested successfully on ItsyBitsy M0 and M4 with test builds. Will merge once Travis is happy!

@kattni kattni merged commit 85a5276 into adafruit:3.x Jul 9, 2018
@dhalbert dhalbert deleted the 3.x-fix-pull branch May 28, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @kattni