nrf: More cleanup and porting #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
previously requested changes
Jul 10, 2018
ports/nrf/mphalport.c
Outdated
| @@ -72,3 +72,13 @@ void mp_hal_stdout_tx_strn_cooked(const char *str, mp_uint_t len) { | |||
| void mp_hal_stdout_tx_str(const char *str) { | |||
| mp_hal_stdout_tx_strn(str, strlen(str)); | |||
| } | |||
|
|
|||
| void mp_hal_delay_ms(mp_uint_t ms) | |||
| { | |||
There was a problem hiding this comment.
Put curly brace on previous line to make consistent with the rest of the code.
ports/nrf/mphalport.c
Outdated
| } | ||
|
|
||
| void mp_hal_delay_us(mp_uint_t us) | ||
| { |
|
Muscle memory again, I'll try to get better at this! Thanks for the comments, I appreciate consistent code style as well, will fix it! :) |
Thus getting rid of the whole old hal! The module is not needed because the common-hal nRF implementation uses HW RNG anyway.
Merged
|
@dhalbert I fixed the comments you posted, if every thing is to your liking, please merge at your convenience :) |
dhalbert
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.