Fix build board info #10121
Merged
Fix build board info #10121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use board mapping instead of looking for directories
Neradoc
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Alias boards get double the versions, because they are already in board_mapping.
So you don't need the inner loop on alias:
for board_id, board_info in board_mapping.items():
if board_id not in current_info:
changes["new_boards"].append(board_id)
current_info[board_id] = {"downloads": 0, "versions": []}
new_version = {
"stable": new_stable,
"version": new_tag,
"languages": languages,
# add modules, extensions, frozen_libraries explicitly
"modules": support_matrix[board_id]["modules"],
"extensions": support_matrix[board_id]["extensions"],
"frozen_libraries": support_matrix[board_id]["frozen_libraries"],
}
current_info[board_id]["downloads"] = board_info["download_count"]
current_info[board_id]["versions"].append(new_version)With this, it seems all good from what I've been able to see by comparing to the last version on cp.org (with more boards and new modules as expected).
tannewt
commented
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use board mapping instead of looking for directories