waveshare_esp32_s3_geek: fix SPI busses and board_init() #10164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still works fine 😁 |
dhalbert
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Thanks for this fix and thanks to @RetiredWizard for testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds board.SPI for the display SPI bus, and use it in
board.c.Previously the code accidentally instantiated both the SD bus (board.SD_SPI) and overwrote it with the display bus in display_init(), making the SD pins unusable. I can't test it.
Should fix #10161
(fixed rebase shenanigans... I think)