Skip to content

nrf: Fix BLE on nRF52840 after adding the USB functionality #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2018
Merged

nrf: Fix BLE on nRF52840 after adding the USB functionality #1022

merged 1 commit into from
Jul 13, 2018

Conversation

arturo182
Copy link
Collaborator

Need to release the POWER IRQ because the SD takes control over it, so USB and BLE can work at the same time.

@arturo182 arturo182 added this to the 4.0.0 - Bluetooth milestone Jul 13, 2018
@dhalbert dhalbert requested a review from hathach July 13, 2018 12:59
dhalbert
dhalbert approved these changes Jul 13, 2018
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I haven't tested it. Added @hathach for "FYI" and confirmation.

jerryneedell
jerryneedell reviewed Jul 13, 2018
View reviewed changes
Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me -- tested on pca10056

>>> import ble_scan
ADDR:   c8:69:cd:1c:5d:f8
TYPE:   0
RSSI:   -78
        AD_TYPE_FLAGS: 0x1A
        AD_TYPE_MANUFACTURER_SPECIFIC_DATA: 0x4C 0x00 0x10 0x05 0x01 0x10 0xC8 0x70 0xC0

@arturo182
Copy link
Collaborator Author

Yes I also verified :)

@dhalbert dhalbert merged commit 2f877bd into adafruit:master Jul 13, 2018
@arturo182 arturo182 deleted the nrf_usb_ble branch July 13, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell left review comments

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt Awaiting requested review from tannewt

@hathach hathach Awaiting requested review from hathach

Assignees
No one assigned
Labels
bug nordic
Projects
None yet
Milestone
4.0.0 - Bluetooth
Development

Successfully merging this pull request may close these issues.
3 participants
@arturo182 @dhalbert @jerryneedell