Add working_directory for subsequent code file #10263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully #10269 will make enough space for this. |
This allows subfolders to be treated similar to / for multiple apps within different folders. Also, fix up the internal current working directory so it doesn't depend on volumes. Fixes micropython#9045 and fixes micropython#8409.
ca1199b to
3377765
Compare
dhalbert
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Interesting that the .. normalization was done for LFS here: micropython@d3ea28d. Too bad it's not in a general place.
I don't see any issues, but I think you could write some tests for this with a toy filesystem as is done in some other MicroPython tests. There are a lot of edge cases here. Not asking you to do this now, but it would be worth it when writing similar kind of code in the future.
Thanks!
|
I think it'd be good for us to setup some C level unit tests. There's no reason to run it through the Python VM. The unix port is more MicroPython than CircuitPython, which makes it hard too. |
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows subfolders to be treated similar to / for multiple apps within different folders.
Also, fix up the internal current working directory so it doesn't depend on volumes.
Fixes #9045 and fixes #8409.