Skip to content

Phaser Audio Effect #10304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2025
Merged

Phaser Audio Effect #10304

merged 5 commits into from
May 2, 2025

Conversation

relic-se
Copy link

@relic-se relic-se commented May 1, 2025

Added a new audiofilters.Phaser. Based on the Godot AudioEffectPhaser with the following modifications:

  • Direct frequency control (ideally with a synthio.LFO)
  • Variable filter stages
  • depth renamed to mix and limited to 1.0

@gamblor21 for interest

@tannewt tannewt requested a review from gamblor21 May 1, 2025 22:29
@todbot
Copy link

todbot commented May 2, 2025

Just tried out this Phaser effect. It sounds awesome. Upvote.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Thanks!

@tannewt tannewt merged commit 054c0c1 into adafruit:main May 2, 2025
55 checks passed
@relic-se relic-se deleted the phaser branch May 2, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants