Add end() method to MixerVoice to allow samples to finish playing bef… #10309
+37
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 5, 2025
| //| sample to finish before looping again "" | ||
| //| ... | ||
| //| | ||
| STATIC mp_obj_t audiomixer_mixervoice_obj_end(mp_obj_t self_in) { |
There was a problem hiding this comment.
Suggested change
| STATIC mp_obj_t audiomixer_mixervoice_obj_end(mp_obj_t self_in) { | |
| static mp_obj_t audiomixer_mixervoice_obj_end(mp_obj_t self_in) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
endmethod to the MixerVoice class within the auidomixer library.Calling this method will set the object's
loopflag toFalse. This is different than thestopmethod, which ends the sample immediately, and instead allows any looping sample to play thorugh its entirety before ending.This feature was added to fix a problem where samples ended via
stopcreated a loud clicking sound from the connected speaker. By allowing the samples to play out fully, the clicking does not exist.I have tested this on multiple looping audio samples.