Skip to content

Update ping action version #10389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Update ping action version #10389

merged 1 commit into from
May 31, 2025
+1 −1

Conversation

tekktrik
Copy link
Member

I updated this action to be a Python-based composite action to simplify maintaining it. The user-facing API was kept the same, but since it was a decently large internal overhaul, it got a bump to the major version.

dhalbert
dhalbert reviewed May 31, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the action code, which looks fine. How did you test it?

@tekktrik
Copy link
Member Author

Yeah, I have a private repository I've been using to develop and test - works as expected!

dhalbert
dhalbert approved these changes May 31, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit d7638e1 into adafruit:main May 31, 2025
617 checks passed
@tekktrik tekktrik deleted the dev/ping-action branch May 31, 2025 16:44
@dhalbert
Copy link
Collaborator

dhalbert commented Jun 2, 2025

Here's a failure in use: not sure what went wrong: https://github.com/adafruit/circuitpython/actions/runs/15392824491/job/43306024238

@tekktrik
Copy link
Member Author

tekktrik commented Jun 2, 2025

Thanks, I'll investigate this today and submit a fix. Sorry for the hassle.

@tekktrik
Copy link
Member Author

tekktrik commented Jun 2, 2025

Okay I can reproduce this, it occurs for some reason when the action should short circuit pass because a non-matching label is applied. Fix is WIP.

@tekktrik
Copy link
Member Author

tekktrik commented Jun 2, 2025

I must have gotten too greedy with trying to blanket-catch errors and caught the intended SystemExit exception as well, and must have not tested after this fact. Issue has been patched in the v2 branch - see test results here: https://github.com/tekktrik/test-repo/issues

@dhalbert
Copy link
Collaborator

dhalbert commented Jun 2, 2025

OK, great -- thanks! I'll let you know of course if I see another failure.

@tekktrik
Copy link
Member Author

tekktrik commented Jun 2, 2025

Failed action runs have been re-run and now pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekktrik @dhalbert