nrf: rework of pin files; add new boards; add pin claiming #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
commented
Aug 31, 2018
arturo182
requested changes
Aug 31, 2018
…ca10056; improve board names for pca boards
arturo182
requested changes
Sep 1, 2018
tannewt
previously requested changes
Sep 4, 2018
|
Will Approve after this is updated to fix the conflict. Thanks! |
|
@tannewt had to redo after merge due to pin struct changes; I forgot to try a recompile. Ready for another mini-review and travis is happy. Tested with a NeoPixel ring. |
|
Fixes #1089 |
|
@dhalbert I see PCA10059 was added by this PR, but I don't see it among the files released for circuitpython 3.1.1. Should we compile it ourselves to get started for the PCA10059 board? Is there a "getting started" page for that? I don't see the board mentioned on https://github.com/adafruit/circuitpython/tree/master/ports/nrf |
|
@hansmbakker We've done a lot more work on 4.x. Either try those releases or test builds from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atmel-samdport, so that pin definitions can be commented and formatted.atmel-samd, instead of storing port separately. Simplifies some code and allows them to be passed around more easily.atmel-samd. Add calls toclaim_pin()andpin_reset_number()in peripheral classes.D0,SCL, etc.pin_reset()topin_reset_number()incommon-hal/microcontroller/Pins.cto avoid confusion between routines that take pin objects and those that take pin numbers. Made this change inatmel-samdalso for consistency.neopixel_write.printf()call inmain.ctomp_printf(): was causing DEBUG builds to fail.atmel-samddevices.More work to do in peripherals, including allow multiple instances in some cases, implementing not-yet-implemented. Those are covered in other issues.
@tannewt will merge, but @arturo182 take a look if you wish, because there are changes of interest in your device code.