Skip to content

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 18, 2018

sample rate of 350ksps.

Also added an error check of sample rate.

Fixes #1196

sample rate of 350ksps.

Also added an error check of sample rate.

Fixes micropython#1196
Copy link
Collaborator

@ATMakersBill ATMakersBill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I count as a reviewer with write access, but I pulled Scott's code, built it, ran it on the CPX that failed with the current 3.0 build and his fix worked.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see: ugh, bad datasheet. There's a discussion (in German) about this: https://translate.google.com/translate?hl=en&sl=de&u=https://www.mikrocontroller.net/topic/433420&prev=search
which says 48Mhz is fine.

Do you have another reference as well?

I added a comment here:
https://community.atmel.com/forum/samd11-dac-speed-problem

@dhalbert dhalbert merged commit af7a0ee into adafruit:3.x Sep 19, 2018
@tannewt
Copy link
Member Author

tannewt commented Sep 19, 2018

I couldn't find a reference. I just tried it and verified with the Saleae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants