Skip to content

Update Core Drivers Page [3.x] #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2018
Merged

Update Core Drivers Page [3.x] #1333

merged 3 commits into from
Nov 15, 2018

Conversation

sommersoft
Copy link

master PR soon to follow.

kattni
kattni previously approved these changes Nov 14, 2018
View reviewed changes
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this!! 🌮

I restarted the Travis build, we'll see if it passes.

@sommersoft
Copy link
Author

Yeah, I had restarted the pca10056 build once before. I haven't sent anything this way in a while, so not sure if 3.x builds are perpetually broken for that specific board. 🤷‍♂️

@dhalbert, any insight?

@dhalbert
Copy link
Collaborator

The 3.x pca10056 build has broken because the s140_nrf52_6.0.0-6.alpha SD release (used for nrf52840) has disappeared from the Nordic website. I tried substituting the 6.0.0 release but there were API changes and the code no longer compiles. This is not a problem in master because we well ahead of that alpha release.

dhalbert
dhalbert approved these changes Nov 15, 2018
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the pca10056 build was an unfortunate coincidence. Thanks for this!

@dhalbert dhalbert merged commit 3ace9ea into adafruit:3.x Nov 15, 2018
@sommersoft sommersoft deleted the drivers_page branch November 15, 2018 04:45
@sommersoft
Copy link
Author

No worries! And thank you for digging into the SD issue, even though we ended up scrapping it altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@kattni kattni kattni left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sommersoft @dhalbert @kattni