renamed spi flash to ext flash not to confuse with the actual spi flash #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 22, 2017
| { MP_OBJ_NEW_QSTR(MP_QSTR_EXT_SCK), (mp_obj_t)&pin_PB11 }, | ||
| { MP_OBJ_NEW_QSTR(MP_QSTR_EXT_MOSI), (mp_obj_t)&pin_PB10 }, | ||
| { MP_OBJ_NEW_QSTR(MP_QSTR_EXT_MISO), (mp_obj_t)&pin_PA12 }, | ||
| { MP_OBJ_NEW_QSTR(MP_QSTR_EXT_CS), (mp_obj_t)&pin_PA13 }, |
There was a problem hiding this comment.
Please remove EXT_ from the names and remove the CS line. Its still the CS line for the flash and not on the 2x3 SPI connector.
|
Hi Scott, the last commit should have resolved you change request. please confirm. |
|
I only see one commit in the pull request still. Did you push it to your |
|
Hi Scott, yes, and git says up-to date when I push again to it... thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLASH_SPI were using the same pins as the spi flash on the board. This renames the pins for the user to use the External SPI.