Skip to content

Prepare for 3.1.2 release: Link typo in drivers.rst; update frozen modules; fix nRF builds #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

dhalbert
Copy link
Collaborator

No description provided.

@dhalbert dhalbert requested a review from kattni December 14, 2018 16:13
siddacious
siddacious previously approved these changes Dec 14, 2018
@kattni
Copy link

kattni commented Dec 14, 2018

Travis is failing to build due to an issue with one of the build's download links. Dan will put a fix in eventually. Until then, this PR is approved but waiting on the Travis fix.

@dhalbert dhalbert changed the title Link typo in drivers.rst Prepare for 3.1.2 release: Link typo in drivers.rst; update frozen modules; fix nRF builds Jan 6, 2019
@dhalbert
Copy link
Collaborator Author

dhalbert commented Jan 6, 2019

This minor PR is now fixed and re-purposed for a 3.1.2 release. I fixed the nRF 52832 build and removed the 52840 build, which depended on an alpha version of the SD that is no longer available, and would require significant code changes to upgrade to a non-alpha version.

The main point of the 3.1.2 release is to include serial_bytes_available, which @ATMakersBill is depending on for a Learn Guide.

@dhalbert dhalbert requested a review from ATMakersBill January 7, 2019 00:38
Copy link
Collaborator

@ATMakersBill ATMakersBill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works great - thanks!

Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all of this!

@kattni kattni merged commit 7d17414 into adafruit:3.x Jan 7, 2019
@dhalbert dhalbert deleted the drivers.rst-typo branch January 7, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants