Fix broken mp_stack_check() when using -flto #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age() not to be inlined even with -flto
|
Thank you so much for figuring this out! Its super important for CircuitPython that the stack checking works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144. Force
py/stackctrl.croutines that effectively read the $sp not be to inlined, by usingasm("").MP_NOINLINEis not effective to prevent inlining in this case. Something about-fltomakes these routines not work correctly. They work fine without-flto.With this fix,
MP_STACK_CHECK()stack overflow checking works again with-flto.