Skip to content

A variety of displayio improvements #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 13, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Feb 12, 2019

This changes a number of things in displayio:

  • Introduces BuiltinFont and Glyph so the built in font can be used by libraries. For boards with
    a font it is available as board.TERMINAL_FONT. Fixes Add text support #1172
  • Remove _load_row from Bitmap in favor of bitmap[] access. Index can be x/y tuple or overall index. Fixes Add subscr to Bitmap #1191
  • Add width and height properties to Bitmap.
  • Add insert and [] access to Group. Fixes insert/delete into displayio Group #1518
  • Add index param to pop on Group.
  • Terminal no longer takes unicode character info. It takes a BuiltinFont instead.
  • Fix Terminal's handling of [###D vt100 commands used when up arrowing into repl history.
  • Add x and y positions to Group plus scale as well.
  • Add bitmap accessor for BuiltinFont

This changes a number of things in displayio:
* Introduces BuiltinFont and Glyph so the built in font can be used by libraries. For boards with
  a font it is available as board.TERMINAL_FONT. Fixes micropython#1172
* Remove _load_row from Bitmap in favor of bitmap[] access. Index can be x/y tuple or overall index. Fixes micropython#1191
* Add width and height properties to Bitmap.
* Add insert and [] access to Group. Fixes micropython#1518
* Add index param to pop on Group.
* Terminal no longer takes unicode character info. It takes a BuiltinFont instead.
* Fix Terminal's handling of [###D vt100 commands used when up arrowing into repl history.
* Add x and y positions to Group plus scale as well.
* Add bitmap accessor for BuiltinFont
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only minor things.

@tannewt
Copy link
Member Author

tannewt commented Feb 12, 2019

@dhalbert Please take another look!

@tannewt
Copy link
Member Author

tannewt commented Feb 12, 2019

Oops, needed to refresh. /me waits again for Travis

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaay!

@dhalbert dhalbert merged commit a61f68f into adafruit:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants