wrong arg type for PWMOut variable_frequency #1641
Conversation
|
@kevinjwalters has tested this successfully: see #1626. |
There was a problem hiding this comment.
Oops! Good find! Thanks @kevinjwalters for the bug and verification.
|
If it was always True then why did my code sometimes work and initialise both PWMs? Is the bool 8 bit and the int 32 bit so it's reading 24 extra bits from somewhere? Would the case where mine worked be if those others 24 bits happened to be 0 for both instantiations? |
|
"always True" was wrong. It was actually almost always True, but not quite all the time, depended on what junk was left over in the memory location. |
|
Do you have an automated way of checking for type discrepancies in the interface between the python and C code? If any of these memory addresses are written to (return values?) then getting the wrong type could be far more hazardous. I glanced at the code and perhaps this particular one is a problem solely within the C code between the declarations and extraction via a union? Is there scope for bugs in Python <-> C too? |
PWMOut was reading a supplied bool arg as an int, so it was almost always True.
Also minor fix to make sure SWRESET is finished before proceeding.
Fixes #1626.