Skip to content

restrict 'make translate' to include only those directories we have ports for #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

restrict 'make translate' to include only those directories we have ports for #1719

merged 1 commit into from
Mar 28, 2019

Conversation

dhalbert
Copy link
Collaborator

Redo of pull request due to intervening changes and submodule changes, which messed up the merge. Also had to make pirkey de_DE build fit.

@dhalbert dhalbert requested a review from tannewt March 27, 2019 20:30
tannewt
tannewt approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 2cc3159 into adafruit:master Mar 28, 2019
@dhalbert dhalbert deleted the restrict-translate-1 branch March 28, 2019 01:25
@deshipu
Copy link

deshipu commented Mar 28, 2019

Should we also exclude extmod/modussl_axtls?

@dhalbert
Copy link
Collaborator Author

If extmod/modussl_axtls is not used by anything, yes, we could. I think the -prune option for find might help. Was this only for esp8266, or is it used to build micropython-coverage for tests or anything like that?

@deshipu
Copy link

deshipu commented Mar 28, 2019

A quick grep shows that it's only mentioned in PY_EXTMOD_O_BASENAME in py/py.mk and was only used in ESP8266 and ESP32 ports. I can see a bunch of other potentially unused modules in there, like moduselect and moduwebsocket.

However, I am not 100% sure if they are not used somewhere without being explicitly mentioned — for example in the UNIX port...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @deshipu @tannewt