Skip to content

Improved readability of Single Byte Bounds code #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2019
Merged

Improved readability of Single Byte Bounds code #1731

merged 3 commits into from
Apr 2, 2019

Conversation

makermelissa
Copy link
Collaborator

@makermelissa makermelissa commented Mar 31, 2019 •
edited
Loading

Just a quick readability refactoring of #1708. Functionality should remain the same.

@tannewt tannewt self-requested a review April 1, 2019 22:27
tannewt
tannewt requested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I think you should remove the & 0xff on each line because it is implied by the assign to uint8_t.

@makermelissa
Copy link
Collaborator Author

Good to know. Thanks.

@makermelissa makermelissa requested a review from tannewt April 2, 2019 05:47
tannewt
tannewt approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the quick follow-up and all of the help.

@tannewt tannewt merged commit 2dda3df into adafruit:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
displayio refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makermelissa @tannewt