Measure and report maximum stack usage. #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add separate cpp flag for enabling modules: MICROPY_DEBUG_MODULES
tannewt
approved these changes
Jul 23, 2017
romanz
pushed a commit
to romanz/micropython
that referenced
this pull request
Mar 17, 2019
Adapted from adafruit#175 f91493c Dan Halbert: Measure and report maximum stack usage. (micropython#175)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code to measure the maximum excursion of the stack. Enabled only when doing a DEBUG build:
make -DDEBUG=1.New debug-only module added:
ustack. This provides:ustack.stack_size()- return the maximum size of the stack.ustack.stack_usage()- return how much stack is currently in use. Same asmicropython.stack_use(), but duplicated here for convenience.ustack.max_stack_usage()- return the maximum excursion of the stack so far since CircuitPython started.Related change: Debugging modules used to be enabled if if the general cpp flag
DEBUGwas defined. However, I created a new#definecalledMICROPY_DEBUG_MODULESso they can be enabled/disabled separately.Also checked into why
NDEBUGmakes the code size a bit smaller (per @tannewt's TODO inatmel-samd/Makefile.NDEBUGis the standard way of disablingassert()statements, so apparently that's the reason. Changed comment to reflect that.(This pull request improves on the previous request #150 and brings it up to date for master.)