Skip to content

add support for USER_C_MODULES #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2019
Merged

add support for USER_C_MODULES #1754

merged 6 commits into from
Apr 17, 2019

Conversation

dmazzella
Copy link

No description provided.

@tannewt
Copy link
Member

tannewt commented Apr 5, 2019

Why do you want this? We will not promise that our internal C APIs are stable. The only way to have something native that is maintained is by merging it into this repo.

@dhalbert
Copy link
Collaborator

dhalbert commented Apr 5, 2019

@tannewt I followed the original MicroPython discussion on this over months. The idea is just to make it lower overhead to add special-purpose modules, segregated in another directory. Anyone using this would need to maintain a fork. I don't think we'd recommend using this except for private stuff. It doesn't flow with shared-bindings, shared-modules, etc. but it does make it easier to add a simple module.

@dmazzella Anything general-purpose (e.g., an FFT module, or something like that), we would like to see submitted to us as a PR, even if it's turned off by default.

@dhalbert
Copy link
Collaborator

dhalbert commented Apr 5, 2019

One advantage of having this in our fork is that it will make merging from upstream easier next time, since it's already included in MPy. At the next merge, we'd either have to merge or discard it (manually).

@tannewt
Copy link
Member

tannewt commented Apr 9, 2019

@dmazzella Please describe what you are using this for.

@tannewt
Copy link
Member

tannewt commented Apr 15, 2019

Feel free to comment on why you need this and I'll reopen. I'll close for now.

@tannewt tannewt closed this Apr 15, 2019
@dmazzella
Copy link
Author

@tannewt sorry if I answer with so much delay.
I use this feature from upstream to isolate the repository of my features from the upstream one. I find the possibility of not having to apply patches, forks or creating branchs to manage my native modules very useful.

@tannewt tannewt reopened this Apr 16, 2019
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this in.

@tannewt tannewt merged commit 713a38d into adafruit:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants