Skip to content

Track a dirty area for in-memory bitmaps #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jul 19, 2019

This fixes the bug that bitmap changes do not cause screen updates
and optimizes the refresh when the bitmap is simply shown on the
screen. If the bitmap is used in tiles, then changing it will
cause all TileGrids using it to do a full refresh.

Fixes #1981

This fixes the bug that bitmap changes do not cause screen updates
and optimizes the refresh when the bitmap is simply shown on the
screen. If the bitmap is used in tiles, then changing it will
cause all TileGrids using it to do a full refresh.

Fixes micropython#1981
@tannewt tannewt added this to the 4.1.0 milestone Jul 19, 2019
@tannewt tannewt requested a review from dhalbert July 19, 2019 00:02
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the algorithm.

@dhalbert
Copy link
Collaborator

Build failed, just looks like make translate needed.

@tannewt
Copy link
Member Author

tannewt commented Jul 19, 2019

Ok, @dhalbert. It should be ready for re-review and pass Travis 🤞 .

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another fantastic speedup!

@dhalbert dhalbert merged commit dbab538 into adafruit:4.1.x Jul 19, 2019
@dhalbert
Copy link
Collaborator

Is this going to be 4.1.0-rc.1, since it was merged into 4.1.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants