-
Notifications
You must be signed in to change notification settings - Fork 1.3k
BLE: more features #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE: more features #2066
Conversation
Tested ble demo examples on feather_nRF52840_express and pca10059. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API comments. Still looking at common-hal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other comments. Please address the previous set.
There are a few corresponding changes now in adafruit/Adafruit_CircuitPython_BLE#16. |
…tines from shared-bindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks!
Characteristic
orDescriptor
data length, and allow setting to fixed length.Descriptor
.Characteristic
properties from keyword arguments to bitmask.Characteristic
andDescriptor
. IntroduceAttribute
class as a notional superclass ofCharacteristic
andDescriptor
which cannot be instantiated: it just provides security constants now.Adapter.address
fetch.CIRCUITPY
be more unique by suffixing last four hex digits of address, e.g.CIRCUITPYa1c4
.Peripheral
to discover services provided by a central.These changes and additions sync up with adafruit/Adafruit_CircuitPython_BLE#16.
Non-BLE:
ports/nrf/make-pins.py
.time_struct
documentation.nibble_to_hex_upper[16]
andnibble_to_hex_lower[16]
arrays for easy printing of hex digits.