Skip to content

BLE: more features #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 16, 2019
Merged

BLE: more features #2066

merged 12 commits into from
Aug 16, 2019

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Aug 15, 2019

  • Discover characteristic descriptors during service discovery
  • Allow specifying Characteristic or Descriptor data length, and allow setting to fixed length.
  • Add GATTC/GATTS read/write for Descriptor.
  • Remove named constants for descriptor UUIDs. Better to just do these in Python.
  • change Characteristic properties from keyword arguments to bitmask.
  • Add setting read/write security levels on Characteristic and Descriptor. Introduce Attribute class as a notional superclass of Characteristic and Descriptorwhich cannot be instantiated: it just provides security constants now.
  • Fix Adapter.address fetch.
  • Make default name CIRCUITPY be more unique by suffixing last four hex digits of address, e.g. CIRCUITPYa1c4.
  • Add peripheral client pairing (no bonding yet).
  • Allow Peripheral to discover services provided by a central.

These changes and additions sync up with adafruit/Adafruit_CircuitPython_BLE#16.

Non-BLE:

  • Delete obsolete ports/nrf/make-pins.py.
  • Fix badly formatted time_struct documentation.
  • Add nibble_to_hex_upper[16] and nibble_to_hex_lower[16] arrays for easy printing of hex digits.

@jerryneedell
Copy link
Collaborator

Tested ble demo examples on feather_nRF52840_express and pca10059.
no issues

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API comments. Still looking at common-hal.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other comments. Please address the previous set.

@dhalbert
Copy link
Collaborator Author

There are a few corresponding changes now in adafruit/Adafruit_CircuitPython_BLE#16.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks!

@tannewt tannewt merged commit 85d7398 into adafruit:master Aug 16, 2019
@dhalbert dhalbert deleted the ble-pairing branch February 29, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants