Fix entry overrides in support matrix generation #2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #2539 The entries in the board's mpconfigboard.mk override any other entries. Also, fixed a warning for bad use of backslash in a string.
sommersoft
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
@deshipu, thanks for spotting this and the fix!
It actually highlights a deeper problem. I think I should've had the base[module]["default_value"] factor in the port-wide configs, versus relying solely on the top-level config.
That is why it wasn't working for the PewPewM4; the top-level is also 0 for network. So by adding the port-wide config to the end of the board config contents, this was being masked and the conditional wasn't flagging the exclusion.
I may address that later, along with the other missing raw-string designators.
|
Just tagging #2021, so I have a mental reference in the future. 🐘 |
|
Note: just built the docs locally. Everything looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2539
The entries in the board's mpconfigboard.mk override any other entries.
Also, fixed a warning for bad use of backslash in a string.