Skip to content

Include filename for 'No such file/directory', etc. #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 4, 2020
Merged

Include filename for 'No such file/directory', etc. #2584

merged 5 commits into from
Feb 4, 2020

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Feb 4, 2020 •
edited
Loading

Fixes #2149 for vfat.

>>> open("foo")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: [Errno 2] No such file/directory: 'foo'

@dhalbert dhalbert requested review from tannewt and ladyada February 4, 2020 18:47
tannewt
tannewt previously approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

@dhalbert dhalbert force-pushed the oserror-with-filename branch from 077664b to 280e20a Compare February 4, 2020 22:09
@dhalbert dhalbert requested a review from tannewt February 4, 2020 23:05
tannewt
tannewt approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! @ladyada is testing it

@dhalbert dhalbert merged commit 433671f into adafruit:master Feb 4, 2020
@dhalbert dhalbert deleted the oserror-with-filename branch February 4, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create "code.py" when creating the filesystem
3 participants
@dhalbert @tannewt @ladyada