Skip to content

Implement to_bytes(..., signed=True) #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

Implement to_bytes(..., signed=True) #2625

merged 1 commit into from
Feb 18, 2020

Conversation

dhalbert
Copy link
Collaborator

Fixes #2579.

Uses existing latent support for signed conversions. It was mostly just the arg parsing. Tests added.

Implementing from_bytes(..., signed=True) is harder: #2624.

@dhalbert dhalbert requested a review from tannewt February 14, 2020 20:15
tannewt
tannewt approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you! @dpgeorge may want to pull this upstream too.

@tannewt tannewt merged commit 850e655 into adafruit:master Feb 18, 2020
@dhalbert dhalbert deleted the to_bytes-signed branch February 29, 2020 02:25
@projectgus projectgus mentioned this pull request Nov 27, 2024
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_bytes() doesn't handle negative numbers properly
2 participants
@dhalbert @tannewt