Add board file for the hacked Trinket M0 Express #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this is actually useful, but since I got it working, I thought I would make the pull request anyways. |
|
Thanks for this! I'm not exactly sure how we want to handle the branding for this since its a hacked up Trinket. I think it'd be ok to have it pulled in. We just likely want to caveat it. |
tannewt
requested changes
Oct 3, 2017
| #endif | ||
|
|
||
| #ifndef USB_DEVICE_PRODUCT_NAME | ||
| # define USB_DEVICE_PRODUCT_NAME "Trinket M0" |
|
|
||
| //! USB Device string definitions (Optional) | ||
| #ifndef USB_DEVICE_MANUFACTURE_NAME | ||
| # define USB_DEVICE_MANUFACTURE_NAME "Adafruit Industries" |
There was a problem hiding this comment.
Change this to make it clear its not officially sanctioned.
| @@ -0,0 +1,39 @@ | |||
| #define USB_REPL | |||
|
|
|||
| #define MICROPY_HW_BOARD_NAME "Adafruit Trinket M0 Express" | |||
|
Done. I hope I didn't miss any. I also changed one "micropython" to "circuitpython" — you might want to do that in other boards too. |
|
Thanks @deshipu ! Which MicroPython did you change? |
|
Ah ok. Thanks!
…On Tue, Oct 3, 2017 at 12:17 PM Radomir Dopieralski < ***@***.***> wrote:
e6be16f#diff-c0809c6aa2f2d9455e27475a2bfe59fbL79
<e6be16f#diff-c0809c6aa2f2d9455e27475a2bfe59fbL79>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#303 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADNqT2K-NBxHY-uPKrUY8bk0F9wr4ijks5soogygaJpZM4PrVdx>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board definition for a hacked Trinket M0 with added flash chip.
Based on https://daveastels.com/2017/09/01/trinket-m0-express-hack/
Details at https://hackaday.io/project/21578-pewpew-featherwing/log/68146-replicating-the-trinket-m0-express-hack