Fix bug with socket.recv_into size == 0. #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It returned 0 when it should have filled the buffer. Python reference: https://docs.python.org/3/library/socket.html#socket.socket.recv_into
1 task
|
Tested on Saola-R with latest Requests. This change fixes the |
jepler
approved these changes
Sep 12, 2020
There was a problem hiding this comment.
This an improvement to Python3 compatibility. However, I note that standard Python signals an error when the specified size is nonzero and bigger than the buffer, which this code doesn't do (yet):
>>> import socket
>>> b = bytearray(7)
>>> s = socket.socket()
>>> s.recv_into(b, 8)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: buffer too small for requested bytes
Feel free to merge and treat this as a separate issue if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It returned 0 when it should have filled the buffer.
Python reference: https://docs.python.org/3/library/socket.html#socket.socket.recv_into