ESP32S2 - Fix SPI's SD card issue, add pin protections #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
previously approved these changes
Sep 21, 2020
tannewt
requested changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the same fix for ESP3-S2 as was previously done for STM32 (PR: #3431, issue: #3176). Details are more or less the same as the previous fix, and while I did not test precise timings in this case we can probably assume the same small loss in transmission speed at higher SPI baudrates due to the
memset()involved. Tested on Saola 1 Wrover compared to a control case where SD card was not working. Test sketch.Also adds in some precautionary exceptions for cases where either MOSI and MISO are unset, which would cause IDF errors and null reference exceptions during reboots.
Resolves #3396, part one of addressing #3447