Fix missing nproc on macOS
#3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
396979a breaks building on macOS: `nproc` is a Linux thing, use a cross-platform alternative.
jepler
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Thank you! The lone build failure appears to be unrelated and I've added #3578 to hopefully address it. (not that it matters, as running Python is a perfectly good alternative, but is the alternative shell command getconf _NPROCESSORS_ONLN portable?)
|
I can’t say anything about general portability, but |
|
I tried this PR on a Mac and on a Linux system -- built Pyportal -- works OK for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3541 (396979a) breaks building on macOS, which doesn’t have an
nproccommand. That seems to be a Linux thing. The equivalent would besysctl -n hw.logicalcpu, but since I can’t find any existing platform distinctions in the makefiles, I chose to call Python for a cross-platform solution. (Credits to https://stackoverflow.com/questions/1715580.)