Skip to content

RGBMatrix: Detect invalid bit_depth selection #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2020
Merged

RGBMatrix: Detect invalid bit_depth selection #3661

merged 3 commits into from
Nov 12, 2020

Conversation

jepler
Copy link

@jepler jepler commented Nov 9, 2020

Closes #3650

@FoamyGuy
Copy link
Collaborator

FoamyGuy commented Nov 9, 2020

I tested this with the code from the issue and confirmed it does now throw this error ValueError: Bit depth must be from 1 to 6 inclusive, not 0 and does not lead to any bad state. CIRCUITPY, and the REPL remain accessible.

dhalbert
dhalbert previously approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for arg validation!

@dhalbert
Copy link
Collaborator

dhalbert commented Nov 9, 2020

Needs make translate

@jepler jepler changed the base branch from main to 6.0.x November 9, 2020 15:48
@jepler
Copy link
Author

jepler commented Nov 9, 2020

I also retargeted this at 6.0.x, we'll want to merge up into main at some point

@jepler jepler force-pushed the protomatter-error-checking-6x branch from 39e5a4f to 5554c27 Compare November 9, 2020 15:50
@dhalbert
Copy link
Collaborator

dhalbert commented Nov 9, 2020

I think we could omit this from 6.0.0 if rc.1 is going to be promoted to final, so I'm not going to merge this yet (and it needs make translate again on 6.0.x, due to the different branch).

@tannewt
Copy link
Member

tannewt commented Nov 9, 2020

I'd be ok including this in 6.0.0 without an RC. It's extremely low risk.

@dhalbert
Copy link
Collaborator

@jepler could you make translate and try another push? I can put this in 6.0.0.

@dhalbert dhalbert self-requested a review November 11, 2020 19:26
dhalbert
dhalbert approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed a "make translate" to finish this off.

@dhalbert dhalbert merged commit 105ec12 into adafruit:6.0.x Nov 12, 2020
@jepler jepler deleted the protomatter-error-checking-6x branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rgbmatrix.RGBMatrix with bit_depth=0 puts board in to bad state
4 participants
@jepler @FoamyGuy @dhalbert @tannewt