Skip to content

Round BLE timing values; fix timeout check #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2021
Merged

Round BLE timing values; fix timeout check #3964

merged 1 commit into from
Jan 12, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jan 10, 2021 •
edited
Loading

Fixes #3942.
Fixes #2930.

  • Fix reversed logic for _bleio.start_scan() no timeout check in nrf.
  • Use error-checking float conversion in _bleio float argument validation.
  • Round _bleio float timeout values to nearest integer quantum, instead of truncating. This solves the problem of 0.02 being not quite big enough due to float representation issues.
  • Fix one float conversion in _pixelbuf that was not using the error-checking object-to-float conversion routine.

@dhalbert dhalbert requested a review from tannewt January 10, 2021 18:20
tannewt
tannewt requested changes Jan 11, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

@dhalbert dhalbert requested a review from tannewt January 12, 2021 00:19
tannewt
tannewt approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 4db5565 into adafruit:main Jan 12, 2021
@dhalbert dhalbert deleted the ble-timing-fixes branch January 13, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dhalbert @tannewt