Skip to content

ESP32-S2 update docs to match code usage of IPPROTO_* #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

ESP32-S2 update docs to match code usage of IPPROTO_* #3980

merged 2 commits into from
Jan 21, 2021

Conversation

anecdata
Copy link
Member

IPPROTO_IP vs. IPPROTO_IPV6 is currently determined based on family, rather than passed in as a parameter.

Adafruit CircuitPython 6.1.0-rc.0-12-gf07dd487a-dirty on 2021-01-12; Saola 1 w/Wrover with ESP32S2
>>> import socketpool
>>> dir(socketpool)
['__class__', '__name__', 'Socket', 'SocketPool']
>>> dir(socketpool.SocketPool)
['__class__', '__name__', 'AF_INET', 'AF_INET6', 'SOCK_DGRAM', 'SOCK_RAW', 'SOCK_STREAM', 'getaddrinfo', 'socket']

@anecdata
Copy link
Member Author

IPPROTO_TCP is not used in the current ESP32-S2 context.

@dhalbert dhalbert requested a review from tannewt January 13, 2021 16:09
tannewt
tannewt requested changes Jan 13, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The suggestion should fix the build.

@anecdata @tannewt
Update shared-bindings/socketpool/SocketPool.c
e703e06 
Co-authored-by: Scott Shawcroft <scott@tannewt.org>
@anecdata anecdata added the espressif applies to multiple Espressif chips label Jan 14, 2021
@anecdata anecdata requested a review from tannewt January 21, 2021 22:43
tannewt
tannewt approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 10a44af into adafruit:main Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
espressif applies to multiple Espressif chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anecdata @tannewt