Skip to content

Fix round(). #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2017
Merged

Fix round(). #413

merged 1 commit into from
Nov 7, 2017

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Nov 7, 2017

Don't split a statement with a #pragma. It breaks the compiled output. Fixes #410.

@dhalbert dhalbert requested a review from tannewt November 7, 2017 01:11
tannewt
tannewt approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure looks unrelated. I assume it just needs a poke.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Nov 7, 2017

Test failure was the the usual "lock_3" failure.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Nov 7, 2017

I will merge more 2.x fixes into master on a batch basis, unless you would like separate master PR's for each.

@dhalbert dhalbert merged commit d9a19c4 into adafruit:2.x Nov 7, 2017
@tannewt
Copy link
Member

tannewt commented Nov 7, 2017 via email

@dhalbert dhalbert mentioned this pull request Nov 7, 2017
Closed
@dhalbert dhalbert deleted the fix_round branch November 8, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt