Add RP2040 displayio.ParallelBus Support #4130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Feb 5, 2021
|
#4251 includes the new init code. Sorry for blocking this! |
|
#4251 has been merged so maybe that un-sticks this PR? |
Hope to get to it this weekend, shouldn't take long (once I figure out how to pull in that other PR to my branch) |
90e4bfb to
95069ed
Compare
jepler
reviewed
Mar 5, 2021
|
Tested on the Feather RP2040 and works. |
|
I think this is really close, but there was one of @tannewt's suggestions that looks like it didn't get incorporated yet. |
tannewt
requested changes
Mar 9, 2021
Looks like a change committed after my last rebase changed the state machine construction. I'll have to fix that and the build is failing. |
7669089 to
307d2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ParallelBus support for the RP2040.
Modified the standard bus to accept frequency to tune the PIO speed. Modified other ports to ignore this parameter which is optional.
Tested on the Raspberry Pi Pico and the 3.5" TFT (product 2050). Tested the modified build on a feather M4 but without a display attached (just to ensure the parameter did not fail)