Skip to content

rp2pio: allow keyboard interrupt while waiting for tx fifo to empty (& stall) #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

rp2pio: allow keyboard interrupt while waiting for tx fifo to empty (& stall) #4309

merged 1 commit into from
Mar 2, 2021

Conversation

jepler
Copy link

@jepler jepler commented Mar 2, 2021

I noticed that one of the busy-waiting loops in the pio I/O code was not allowing a keyboard interrupt to break out of it. Fix it!

@tannewt tannewt self-requested a review March 2, 2021 16:55
tannewt
tannewt approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 2651e15 into adafruit:main Mar 2, 2021
@jepler jepler deleted the rp2040-interrupt-pio branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @tannewt