Skip to content

fix removing past releases from circuitpython.org #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented Apr 12, 2021

Loop on a copy when removing past releases.
Fixes leaving 6.2.0-rc.0 when releasing 6.2.0.

When releasing a new stable, unstable releases would be left in because the past stable was removed.
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semver.compare() can do comparisons too: 6.2.0-rc.0 is < 6.2.0. That would cover more cases, I think.

@tannewt tannewt merged commit 2a78a51 into adafruit:main Apr 12, 2021
@Neradoc Neradoc deleted the patch-1 branch May 28, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants