Skip to content

Add board definition files for ARAMCON2 Badge #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

bmeisels
Copy link

Due to Covid-19 the work on the badge was delayed but finally we are gearing up to host the conference in June.
The badge has been renamed from "AramCon Badge 2020" to "ARAMCON2 Badge".

VID/PID allocated here: #2454

@ladyada
Copy link
Member

ladyada commented Apr 17, 2021

please fix so its passing CI and then tag us to review! :)

@bmeisels
Copy link
Author

bmeisels commented Apr 18, 2021

Fixed the original CI issue.
There seems to be an issue in one of the tests which is unrelated to our board.
I have tried to rerun the CI.
Hopefully that will solve the issue.

@bmeisels
Copy link
Author

@ladyada I rerun the CI and the feather_m4_can fails again.
This doesn't seem to be related to our changes.
Any idea on why this is happening?

@ladyada ladyada requested a review from jepler April 19, 2021 17:02
@jepler
Copy link

jepler commented Apr 19, 2021

This pull request modified the "protomatter" submodule. It has to be set back to how it was in the main branch before this PR can pass CI. Let us know if you need help getting that fixed.

@bmeisels
Copy link
Author

I totally missed that.
Will fix it shortly.
Thanks @jepler !

@ladyada ladyada merged commit 83c768b into adafruit:main Apr 19, 2021
@bmeisels bmeisels deleted the aramcon2-badge branch June 5, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants