RP2040 and ESP32S2: Return correct count from UART.write() #4645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! I will push another commit for that. |
|
Fixed and tested on |
microdev1
previously approved these changes
Apr 22, 2021
|
@microdev1 One more review, if you have time. I just had to bump a cache key to fix the build. Thanks. |
microdev1
approved these changes
Apr 23, 2021
dhalbert
added a commit
to dhalbert/circuitpython
that referenced
this pull request
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UART.write()was always returning zero because it used the inputlenas a countdown.This change is on
6.2.x, and we can merge or cherry-pick this tomain.