Fix PDMIn MEMS microphone support #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closed by mistake. was going to make a cosmetic change but not worth it. |
|
yaaaaaaaaaaaay@! |
tannewt
requested changes
Dec 13, 2017
atmel-samd/Makefile
Outdated
| @@ -146,6 +146,10 @@ endif | |||
| CFLAGS += -Os -DNDEBUG -flto $(GCC_INLINE_LIMIT) | |||
| endif | |||
|
|
|||
| # Do extra optimization for speed on a few files. | |||
| # e.g.: | |||
| #$(BUILD)/xxx/Something.o: CFLAGS += $(CSUPEROPT) | |||
There was a problem hiding this comment.
I was basically just documenting how to do this, but I'll take it out.
| /* 1788, 1631, 1473, 1315, 1161, 1013, 873, 742, */ | ||
| /* 622, 514, 418, 334, 262, 201, 150, 108, */ | ||
| /* 75, 49, 30, 16, 7, 2, 0, 0 */ | ||
| /* }; */ |
There was a problem hiding this comment.
Wanted to stash them somewhere, but I can save them elsewhere.
shared-bindings/audiobusio/PDMIn.c
Outdated
| //| :param int bit_depth: Final number of bits per sample. Must be divisible by 8 | ||
| //| :param bool mono: True when capturing a single channel of audio, captures two channels otherwise | ||
| //| :param int oversample: Number of single bit samples to decimate into a final sample. Must be divisible by 8 | ||
| //| :param int microphone_startup_msecs: milliseconds to wait after starting microphone clock |
There was a problem hiding this comment.
How about taking taking float seconds to be consistent with time.sleep?
There was a problem hiding this comment.
That's a good idea. I considered this and then for some reason thought float might not be available, which is wrong: we depend on float
|
not done - didn't do float mic time yet |
|
Ready to re-review. Squash merge if you like due to multiple commits. |
This was referenced Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PDMInobject is created, and run it all the time, so the user code doesn't have to wait for microphone startup, which can be 10ms or even 100ms.PDMInis first created, based on new optional parametermicrophone_startup_msecs.record()returns number of samples actually recorded, so you can see if it's not keeping up.Note: I tried 128x oversampling instead of 64x, but the code cannot keep up at 24kHz or above sampling. 128x would reduce the high-frequency noise by 6db.