-
Notifications
You must be signed in to change notification settings - Fork 1.3k
reduce SPI display baudrate from 60 MHz to 5 MHz to eliminate display glitch #4793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the test I did and after a couple days I have seen no graphic glitches on my FunHouse. I'd like to get someone else to look at it to approve since I was also involved in fixing this.
Thanks @gamblor21. Also don’t have the hardware so it will be good if someone else can run it on their FunHouse board. |
Here's a Thing that we can add - its a bit more effort |
Here's a quick first look at what it might take to split out the sending of "setup" vs "bulk data" with different speeds. Data is sent to the display using a structure One option is to add a flag to the Will need to consider how far-reaching this change will be, since all displayio bus types use a |
I think there is already a command/data flag that could be used for this? |
I think having two baudrates would be the best fix for this (and 7.x is a good time to do it!). command vs data is given with |
I talked to @kmatch98 and I am going to take a look at a new PR with the baud rate change. I will update the issue as well. If a short term fix is required this PR would still be a good idea. |
I remember there was some further testing with dynamic baud rate changes, but I don't remember the results. Could you record them here? |
The variable baud rate for commands vs display was found to have no affect on the reliably of the display so I stopped work on that aspect. The overall baud rate can still be controlled. I need to update the original issue with some more findings but still no solution. This PR would fix the issue but is more of a band aid then a long term solution. |
@ladyada should we merge this for now to fix existing FunHouse (et al) issues temporarily while we explore further? |
I will test this again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no glitches with this change, so let's merge it for now, and we'll keep some kind of issue open about doing more research about the fundamental problem.
This is a workaround to eliminate the display glitch reported in: #4775
This PR reduces the display SPI speed from 60 MHz to 5 MHz.
(Note: Not sure if this is a workaround or a fix, since it is currently unclear why the display glitches occur at higher SPI speeds. The same glitches occurred on ILI9341- and ST7789- driver displays. Perhaps this is an issue with the ESP32-S2 SPI timings at higher speeds.)