-
Notifications
You must be signed in to change notification settings - Fork 1.3k
merge from 2.2.0 + fix up board defs #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. bidirectional SPI support (@microbuilder please check) 2. slight changes in DigitalIO types 3. placeholders (not implemented yet) for single/double-click bootloader support
@tannewt Fixed up things that broke the build. @microbuilder, note that there are a few changes in the nrf/ dir to make things compile, and I implemented bidirectional SPI by implementing one new routine (you can check that -- it was a guess based on the the read and write routines). |
FYI - I was able to merge this PR into master and build/load the code into my feather52 - Seems to be working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo and a note about board specific files.
*/ | ||
/* | ||
* Support and FAQ: visit <a href="http://www.atmel.com/design-support/">Atmel Support</a> | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think all of these conf_* files are needed with ASF4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaned up (+more).
#LD_FILE = boards/samd21x18-bootloader.ld | ||
USB_VID = 0x239A | ||
USB_PID = 0x801F | ||
USB_PRODUCT = "UGame" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small u here because its for micro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tnx
ready to re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Thanks!
Hi Dan, sorry just saw the email alert for this. :( Looks good to me though! |
@microbuilder Feel free to add comments to PRs after they are merged. The author can always follow up with an additional PR. |
All atmel-samd builds are going into safe mode on ctrl-D after this merge (tnx @jerryneedell). So some issue somewhere. |
Merge bugfixes and additions from 2.2.0 to master.
Difficult merge. Checked a number of merges by hand. Non-Adafruit boards added but I did not try to build them.
Merged in 2.2 double-tap support in .ld files (@tannewt: you might double-check these).
CPX SPI flash support added, but not tested.