Skip to content

Update all implementations of spi read to honor write_value #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

jepler
Copy link

@jepler jepler commented Aug 18, 2021

(nrf, rp2040, and cxd56)

.. as well as a misleading comment that said that read always output zeros.

Closes: #3447

…e_value

(nrf, rp2040, and cxd56)

.. as well as a misleading comment that said that read always output
zeros.

Closes: adafruit#3447
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Thanks for picking this up!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking all of the implementations!

@microdev1 microdev1 merged commit 60c0271 into adafruit:main Aug 20, 2021
@jepler jepler deleted the issue3447 branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check write_value on ESP32-S2 and other ports
3 participants