Skip to content

Update tinyusb for samd and rp2040 improvements #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 2, 2021

The improvements are based on the USB compliance tests.

The improvements are based on the USB compliance tests.
@tannewt tannewt added this to the 7.0.0 milestone Sep 2, 2021
@tannewt tannewt requested a review from hathach September 2, 2021 01:26
@rsbohn
Copy link

rsbohn commented Sep 2, 2021

Fixes the missing CIRCUITPYTHON drive issue from earlier builds on RPi Pico RP2040. (tested on Windows 10)

@hathach
Copy link
Member

hathach commented Sep 2, 2021

I am doing compliance verification test for samd and rp2040, will report result in a few minutes.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both SAM51 and Rp2040 passed all the Compliance Test (chapter 9, HID, MSC) as expected 👍 .

However, SAMD21 (tested on M0 metro) has issue with following chapter9 test cases:

  • TD 9.16 Enumeration Test where the host repeatedly issue bus reset + enumeration for 150 times and
  • sometime TD9.9 Halt Endpoint Test.

Note: SAMD21 passed that same tests on my simple example, it is rather similar to a previous issue where setup packet is missed on samd21 as mentioned in this note https://github.com/hathach/tinyusb/blob/master/src/portable/microchip/samd/dcd_samd.c#L50 Maybe it does not completely solve the issue, probably involve race condition. I will look more closely at this later on.

For now the PR look great, we should merge it since it fix issue with rp2040. I will also be doing more tests with stm32f4/esp32s2/imxrt to make sure it doesn't break other ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants